RFR: JDK-8294427 - Check boxes and radio buttons have rendering issues on Windows in High DPI env [v14]

Alexey Ivanov aivanov at openjdk.org
Mon Jun 12 20:26:00 UTC 2023


On Mon, 8 May 2023 18:46:42 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>>> It may be useful to be able to run Java on previous versions though, yet it's not a priority.
>> 
>> Then probably it is better to add a fallback since that method was added to the win 10 after GA, and it does not exist in the early version.
>
>> > It may be useful to be able to run Java on previous versions though, yet it's not a priority.
>> 
>> Then probably it is better to add a fallback since that method was added to the win 10 after GA, and it does not exist in the early version.
> 
> But the earlier versions of Windows 10 are already unsupported, including the one where the `OpenThemeDataForDpi` function was added.
> 
> If required, the fallback could be implemented under a new bug. ~~Anyway, I don't have a strong opinion on this matter.~~

I think it's *unfeasible* to provide the fallback to keep the code simpler.

If `OpenThemeDataForDpi` isn't available, we cannot get per-DPI images. Then we have to fallback to using the DPI of the main display and scale up / down all the returned values and images.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13701#discussion_r1227202738



More information about the client-libs-dev mailing list