RFR: 6664309: Docking point of a floating toolbar changes after closing

Tejesh R tr at openjdk.org
Wed Jun 14 09:37:57 UTC 2023


On Tue, 13 Jun 2023 09:53:01 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Issue is if we create a floating JToolBar at the EAST side and drag it and then if we close the floating toolbar, then it gets docket at NORTH side instead of the EAST side where it was docked before being floated.
> This is because of some contentious code in BasicToolBarUI where we change the constaint to NORTH if it is EAST/WEST.
> I could not find any JBS which did that code change.
> 
> Albeit, removing that piece of code does not cause regression in "clientlibs" jtreg/jck tests in addition to solve this anomaly, so thought, removing the code seems prudent..

test/jdk/javax/swing/JToolBar/TestToolBarConstraint.java line 41:

> 39: import javax.swing.SwingUtilities;
> 40: import javax.swing.SwingConstants;
> 41: import javax.swing.WindowConstants;

Importing `WindowConstants` can be removed, since its not used.

test/jdk/javax/swing/JToolBar/TestToolBarConstraint.java line 69:

> 67:     }
> 68: 
> 69:     private static void creatUI() {

Typo for method name(`createUI`).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14444#discussion_r1229309471
PR Review Comment: https://git.openjdk.org/jdk/pull/14444#discussion_r1229312491



More information about the client-libs-dev mailing list