RFR: 8296972: [macos13] java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java: getExtendedState() != 6 as expected. [v2]

Phil Race prr at openjdk.org
Wed Jun 14 20:12:59 UTC 2023


On Mon, 12 Jun 2023 22:29:25 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> added displayChanged call to CPlatformWindow when frame first needs to deiconify or unmaximize
>> All client tests passed after change
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   use realsync to flush native queue

I don't like the idea of a delay in either of the ways discussed here.
And although I do think that its much better to wait for delivery of an event,  I'm not sure I understand the windowState listener proposal.
How do you know in this code that the transition of
iconified-> normal will then followed by normal->maximised ?
Perhaps you'll wait for ever ?
But I don't know what the macOS native model is for all of this.
This sequence is kind of odd and I'm curious what happens on older macOS releases - Sergey touched on this but I don't see direct followup.
There seems to be assumptions it was like this previously but now it is slower ?

I suggest explicit verification of what happens on macOS 12.6.
Are we now getting two native events when there used to be only one ?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14226#issuecomment-1591904154



More information about the client-libs-dev mailing list