RFR: 8301606: JFileChooser file chooser details view "size" label cut off in Metal Look&Feel

[Alexey Ivanov]

On Thu, 15 Jun 2023 05:35:42 GMT, Tejesh R <tr at openjdk.org> wrote:

> > > Although this might be a bug in insets but for this issue, I guess in native filechooser, "Size" is left aligned which is what we follow.. I think in Java Windows L&F too, it is right aligned which I think we should rectify otherwise it can come as another bug that we are not following native look..
> > 
> > 
> > Java L&F may not follow what native File Explorers / Navigators do — after all, it's a Java Look-and-Feel.
> > On Windows, Explorer displays the Size header left-aligned as all other headers, yet the values in the Size column are right-aligned. If Swing doesn't allow different alignment for the header cell and data cells in a column, then we should preserve right-alignment.
> 
> Hmm, I do have a fix if we are planning to make it similar to native (Window, Linux and MacOS). And FYI, windows native API [getdetailsof](https://learn.microsoft.com/en-us/windows/win32/api/shobjidl_core/nf-shobjidl_core-ishellfolder2-getdetailsof) gives the alignment for columns irrespective of header/data, which is RIGHT alignment for `Size` column. If it is still debatable, then will it be better to open a new bug on Size alignment issue and handle it there?

Here's a screenshot of Windows File Explorer:

![Windows File Explorer: Size column is right-aligned, its header is left-aligned](https://github.com/openjdk/jdk/assets/70774172/5b2c13c5-fc7a-47d6-9804-4b5dace0c1d6)

As you can see, the Size column values are right-aligned, its header remains left-aligned as other headers.

In [this comment](https://github.com/openjdk/jdk/pull/9327#issuecomment-1204836731), @kumarabhi006 attached a screenshot of a File Navigator in Oracle Linux: it shows left-aligned for the Size column.

If it's decided to change the alignment of the Size column in Metal L&F, it must be done separately in its own bug. But I don't think we should change it.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14464#issuecomment-1592572844