RFR: 8006421: GraphicsConfiguration of a frame is changed when the frame is moved to another screen [v5]

[Tejesh R]

On Thu, 15 Jun 2023 21:37:09 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Updated based on review comments
>
> src/java.desktop/macosx/classes/sun/lwawt/macosx/CFileDialog.java line 205:
> 
>> 203:     public GraphicsConfiguration getAppropriateGraphicsConfiguration(
>> 204:             GraphicsConfiguration gc)
>> 205:     {
> 
> Could you please move the brace to the line 204 to match the overall style of the file?

Updated.

> src/java.desktop/unix/classes/sun/awt/X11/XWindowPeer.java line 240:
> 
>> 238:             XToolkit.awtUnlock();
>> 239:         }
>> 240:     }
> 
> The same code is already in XCanvasPeer.
> 
> XWindowPeer is a descendant of XCanvasPeer, there is no need to repeat the code here.

Updated.

> src/java.desktop/windows/classes/sun/awt/windows/WWindowPeer.java line 671:
> 
>> 669:         return gc;
>> 670:     }
>> 671: 
> 
> Same here, WWindowPeer is a WCanvasPeer descendant.

Updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14246#discussion_r1231928415
PR Review Comment: https://git.openjdk.org/jdk/pull/14246#discussion_r1231928510
PR Review Comment: https://git.openjdk.org/jdk/pull/14246#discussion_r1231928769