RFR: 8283214: [macos] Screen magnifier does not show the magnified text for JcomboBox [v2]

[Abhishek Kumar]

On Mon, 19 Jun 2023 08:49:21 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicComboBoxUI.java line 1128:
>> 
>>> 1126:     public Accessible getAccessibleChild(JComponent c, int i) {
>>> 1127:         // 0 = the popup
>>> 1128:         // 1 = the editor
>> 
>> The comment here needs to be updated
>
> Sure, I will update.

Updated.

>> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicComboBoxUI.java line 1146:
>> 
>>> 1144:                         && (arrowButton instanceof Accessible)) {
>>> 1145:                     return (Accessible) arrowButton;
>>> 1146:                 }
>> 
>> How about to idiomatize the code a bit by using Java 14's enhanced `instanceof`?
>
> Yeah it can be done to use enhanced `instanceOf`.

Updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14497#discussion_r1233771736
PR Review Comment: https://git.openjdk.org/jdk/pull/14497#discussion_r1233771503