RFR: 8307145: windowsaccessbridge.dll is missing 4 critical methods in its C API [v2]
Julian Waters
jwaters at openjdk.org
Wed Jun 21 05:32:46 UTC 2023
> In windowsaccessbridge(-64).dll the following methods are exported in a def file to C API which in turn call their real implementation, which are instance methods of the class WinAccessBridge:
>
> addJavaEventNotification
> removeJavaEventNotification
> addAccessibilityEventNotification
> removeAccessibilityEventNotification
>
>
> However, they are nowhere to be seen in the actual C interface, in AccessBridgeWindowsEntryPoints.cpp. Your guess is as good as mine as to how on earth MSVC is still capable of compiling and linking this without any errors whatsoever, but in any case, this is a severe oversight and should be properly defined in the C API lest this happy accident within MSVC is fixed by Microsoft in the future
Julian Waters has updated the pull request incrementally with three additional commits since the last revision:
- Revert AccessBridgeWindowsEntryPoints.h
- Remove from WinAccessBridge.DEF
- Revert AccessBridgeWindowsEntryPoints.cpp
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/13734/files
- new: https://git.openjdk.org/jdk/pull/13734/files/ef810f7f..835513ce
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=13734&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=13734&range=00-01
Stats: 34 lines in 3 files changed: 0 ins; 34 del; 0 mod
Patch: https://git.openjdk.org/jdk/pull/13734.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/13734/head:pull/13734
PR: https://git.openjdk.org/jdk/pull/13734
More information about the client-libs-dev
mailing list