RFR: 8307145: windowsaccessbridge.dll is missing 4 critical methods in its C API [v2]

[Daniel Jeliński]

On Wed, 21 Jun 2023 05:32:46 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> In windowsaccessbridge(-64).dll the following methods are exported in a def file to C API which in turn call their real implementation, which are instance methods of the class WinAccessBridge:
>> 
>> addJavaEventNotification
>> removeJavaEventNotification
>> addAccessibilityEventNotification
>> removeAccessibilityEventNotification
>> 
>> 
>> However, they are nowhere to be seen in the actual C interface, in AccessBridgeWindowsEntryPoints.cpp. Your guess is as good as mine as to how on earth MSVC is still capable of compiling and linking this without any errors whatsoever, but in any case, this is a severe oversight and should be properly defined in the C API lest this happy accident within MSVC is fixed by Microsoft in the future
>
> Julian Waters has updated the pull request incrementally with three additional commits since the last revision:
> 
>  - Revert AccessBridgeWindowsEntryPoints.h
>  - Remove from WinAccessBridge.DEF
>  - Revert AccessBridgeWindowsEntryPoints.cpp

LGTM. These methods are not usable outside of the windowsaccessbridge dll. Caller would need a working instance of WinAccessBridge class to pass in `this` parameter, and there's no way to get one outside of the DLL.

-------------

Marked as reviewed by djelinski (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13734#pullrequestreview-1489858272