Integrated: 8307145: windowsaccessbridge.dll erroneously includes private methods in its C API

Julian Waters jwaters at openjdk.org
Wed Jun 21 06:46:12 UTC 2023


On Sat, 29 Apr 2023 19:26:00 GMT, Julian Waters <jwaters at openjdk.org> wrote:

> In windowsaccessbridge(-64).dll the following methods are exported in a def file to C API which in turn call their real implementation, which are instance methods of the class WinAccessBridge:
> 
> addJavaEventNotification
> removeJavaEventNotification
> addAccessibilityEventNotification
> removeAccessibilityEventNotification
> 
> 
> However, they are nowhere to be seen in the actual C interface, in AccessBridgeWindowsEntryPoints.cpp. Your guess is as good as mine as to how on earth MSVC is still capable of compiling and linking this without any errors whatsoever, but in any case, this is a severe oversight and should be properly defined in the C API lest this happy accident within MSVC is fixed by Microsoft in the future

This pull request has now been integrated.

Changeset: 3faba07a
Author:    Julian Waters <jwaters at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/3faba07ae3f961c3b97434d59512d32519cb7a27
Stats:     5 lines in 1 file changed: 0 ins; 5 del; 0 mod

8307145: windowsaccessbridge.dll erroneously includes private methods in its C API

Reviewed-by: djelinski

-------------

PR: https://git.openjdk.org/jdk/pull/13734



More information about the client-libs-dev mailing list