RFR: 8140527: JInternalFrame has incorrect title button width [v2]
Prasanta Sadhukhan
psadhukhan at openjdk.org
Thu Jun 22 03:44:19 UTC 2023
> Title buttons under Widows Classic L&F got their sizes from the XP desktop theme in which button width can be bigger than height. It is construed as XP bug where sizes aren't updated properly so it uses height units for width for XP and later windows. The proposed fix uses the [same technique](https://github.com/openjdk/jdk/blob/a0595761ef35c4eec8cb84326a869b9473cd5bba/src/java.desktop/windows/classes/com/sun/java/swing/plaf/windows/WindowsInternalFrameTitlePane.java#L78-L82) for Classic and forces title buttons to be square and to fit the frame title in height.
>
> Before fix SwingSet2 demo (Windows Classic InternalFrame)
> 
>
> After fix
> 
Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
Review comments
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/14555/files
- new: https://git.openjdk.org/jdk/pull/14555/files/04e8e888..f8467953
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=14555&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=14555&range=00-01
Stats: 9 lines in 3 files changed: 6 ins; 0 del; 3 mod
Patch: https://git.openjdk.org/jdk/pull/14555.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/14555/head:pull/14555
PR: https://git.openjdk.org/jdk/pull/14555
More information about the client-libs-dev
mailing list