RFR: 8309733: [macOS, Accessibility] VoiceOver: Incorrect announcements of JRadioButton
Sergey Bylokhov
serb at openjdk.org
Thu Jun 22 18:50:05 UTC 2023
On Wed, 21 Jun 2023 20:37:01 GMT, Alexander Zuev <kizune at openjdk.org> wrote:
> Only pass value changed event to the native accessibility peer when the value is actually changed. While at fixing it for RadioButton also fixing it for checkbox and toggle button so there is no need to re-visit this file later.
> Also updating the copyright year.
src/java.desktop/macosx/classes/sun/lwawt/macosx/CAccessible.java line 185:
> 183: // Do send check box state changes to native side
> 184: if (thisRole == AccessibleRole.CHECK_BOX) {
> 185: if (newValue != null && !newValue.equals(oldValue)) {
Is it possible to have "newValue == null" and the "oldValue != null"? Do we need to update the native in this case?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14605#discussion_r1238907239
More information about the client-libs-dev
mailing list