RFR: 8140527: JInternalFrame has incorrect title button width [v2]

Alexey Ivanov aivanov at openjdk.org
Thu Jun 22 20:38:02 UTC 2023


On Thu, 22 Jun 2023 03:39:00 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> > I wonder if the values stored in the UI Manager should have this trick applied rather tweaking the values on the fly. If a programmer gets the values from `UIManager` directly, they will get the incorrect value.
> 
> OK. UIManager is also updated with updated width so values will be identical

Can it be modified so that the value for `"InternalFrame.titleButtonWidth"` gets computed based on `"InternalFrame.titleButtonHeight"` using the algorithm in `WindowsIconFactory.java` and `WindowsInternalFrameTitlePane.java` when its value is requested?

This way UIManager automatically returns the value we want; the adjustment logic can be dropped from both classes above.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14555#issuecomment-1603282478



More information about the client-libs-dev mailing list