RFR: 8308780: Fix the Java Integer types on Windows [v9]
Julian Waters
jwaters at openjdk.org
Fri Jun 23 00:19:18 UTC 2023
On Thu, 22 Jun 2023 19:51:42 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> Julian Waters has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Revert "GetDIBits should take an LPVOID"
>>
>> This reverts commit 7dbe5dea84b1afb2235b66da581bcd3c1da4d6ac.
>
> src/java.desktop/windows/native/libawt/windows/awt_MenuBar.cpp line 148:
>
>> 146: }
>> 147:
>> 148: AwtMenuItem* AwtMenuBar::GetItem(jobject target, jint index)
>
> What is the reason for using `jint` instead of `int`?
>
> The member function is used in for-loop which iterates with `int` loop variable. Yet the implementation of `GetItem` up-calls into Java.
I had it as a jint since it upcalls into Java
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14125#discussion_r1239144537
More information about the client-libs-dev
mailing list