RFR: 8308780: Fix the Java Integer types on Windows [v11]
Julian Waters
jwaters at openjdk.org
Fri Jun 23 16:59:07 UTC 2023
On Fri, 23 Jun 2023 16:53:01 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> Hmm, I lean towards jint as I feel it conveys the fact that it is a Java parameter clearer, intuitively to me it makes sense that a Java integer type would still work in a C++ for loop in native code
>
> You're right… it gives a hint it'll be an upcall into Java. Let's go for `jint` then.
>
> I don't think there's a need to change the type of the for-loop variable to `jint`.
Oh no, I didn't mean to change the loop variable, rather that leaving the jint as is should be fine in the for loop
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14125#discussion_r1240044495
More information about the client-libs-dev
mailing list