RFR: 8305667: Some fonts installed in user directory are not detected on Windows [v2]

Phil Race prr at openjdk.org
Fri Jun 23 17:46:09 UTC 2023


On Tue, 13 Jun 2023 14:10:11 GMT, Nikita Gubarkov <ngubarkov at openjdk.org> wrote:

>> `data` array has size of `MAX_BUFFER` like `wname`, but it has a char type, so its size is twice smaller than actual path limit, because paths returned by `RegEnumValueW` use wide chars. We need to double this limit.
>
> Nikita Gubarkov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use malloc instead of fixed size buffers.

So this looks good to me, but I want to run all our automated tests - I don't suppose you did that already ?

-------------

PR Review: https://git.openjdk.org/jdk/pull/13359#pullrequestreview-1495600173



More information about the client-libs-dev mailing list