RFR: 8307934 JRobot.moveMouseTo must access component on EDT [v3]

[Alexey Ivanov]

On Tue, 27 Jun 2023 11:49:00 GMT, Renjith Kannath Pariyangad <duke at openjdk.org> wrote:

>> Hi Reviewers,
>> 
>> I have updated the JRobot.java file for enabling EDT support, along with I have removed warning BUTTON1_MASK with 'BUTTON1_DOWN_MASK'.
>> 
>> Regards,
>> Renjith
>
> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Reordered imports and updated java doc

Other comments haven't been addressed.

> It would be good if you moved the javadoc for the JRobot class to where it belongs: to the class declaration. Now it precedes the import block. [⇈](https://github.com/openjdk/jdk/pull/14354#discussion_r1242285001)

GitHub doesn't allow adding comments to unmodified lines. The javadoc for the class is at lines 24–33:
https://github.com/openjdk/jdk/blob/b482a9c08c500cc260f07cfe11c8aa11c8f066dc/test/jdk/javax/swing/regtesthelpers/JRobot.java#L24-L34

That is it's before the imports, but it has to be before the class declaration at line 45.

> Can you add the `final` modifier to both `DEFAULT_DELAY` and `INTERNAL_DELAY`. [⇈](https://github.com/openjdk/jdk/pull/14354#discussion_r1242270965)

These are the two constants declared at lines 46–47:

https://github.com/openjdk/jdk/blob/b482a9c08c500cc260f07cfe11c8aa11c8f066dc/test/jdk/javax/swing/regtesthelpers/JRobot.java#L46-L47

test/jdk/javax/swing/regtesthelpers/JRobot.java line 194:

> 192:      * Click the first mouse button in the center of the given Component
> 193:      * <p>
> 194:      * <b>Note:</b> This method uses EDT

This instance still uses the old wording.

In [my comment](https://github.com/openjdk/jdk/pull/14354#discussion_r1242274807), I meant updating **all** the notes when I said about *being consistent*.

The `convertRectToScreen` method needs updating as well.

-------------

Changes requested by aivanov (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14354#pullrequestreview-1500730356
PR Review Comment: https://git.openjdk.org/jdk/pull/14354#discussion_r1243648357