RFR: 8307934 JRobot.moveMouseTo must access component on EDT [v4]

Alexey Ivanov aivanov at openjdk.org
Tue Jun 27 14:31:06 UTC 2023


On Tue, 27 Jun 2023 14:10:38 GMT, Renjith Kannath Pariyangad <duke at openjdk.org> wrote:

>> Hi Reviewers,
>> 
>> I have updated the JRobot.java file for enabling EDT support, along with I have removed warning BUTTON1_MASK with 'BUTTON1_DOWN_MASK'.
>> 
>> Regards,
>> Renjith
>
> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Updated java doc and added final to delay

Changes requested by aivanov (Reviewer).

test/jdk/javax/swing/regtesthelpers/JRobot.java line 48:

> 46: public class JRobot extends java.awt.Robot {
> 47:     final private static int DEFAULT_DELAY = 550;
> 48:     final private static int INTERNAL_DELAY = 250;

Please use [the *blessed* modifier order](https://docs.oracle.com/javase/8/docs/api/java/lang/reflect/Modifier.html#toString-int-): `private static final`.

-------------

PR Review: https://git.openjdk.org/jdk/pull/14354#pullrequestreview-1501034446
PR Review Comment: https://git.openjdk.org/jdk/pull/14354#discussion_r1243846370



More information about the client-libs-dev mailing list