RFR: 8307934 JRobot.moveMouseTo must access component on EDT [v5]

Alexey Ivanov aivanov at openjdk.org
Tue Jun 27 15:00:09 UTC 2023


On Tue, 27 Jun 2023 14:44:21 GMT, Renjith Kannath Pariyangad <duke at openjdk.org> wrote:

>> Hi Reviewers,
>> 
>> I have updated the JRobot.java file for enabling EDT support, along with I have removed warning BUTTON1_MASK with 'BUTTON1_DOWN_MASK'.
>> 
>> Regards,
>> Renjith
>
> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Corrected modifiers order

Changes requested by aivanov (Reviewer).

test/jdk/javax/swing/regtesthelpers/JRobot.java line 42:

> 40:  * @library ../../../regtesthelpers
> 41:  * @build JRobot
> 42:  * </pre>

Could you please add `{@code}` to avoid IDE warning about wrong javadoc tags?

That is the javadoc comment should look like this:


 * <pre>{@code
 * @library ../../../regtesthelpers
 * @build JRobot
 * }</pre>

-------------

PR Review: https://git.openjdk.org/jdk/pull/14354#pullrequestreview-1501133980
PR Review Comment: https://git.openjdk.org/jdk/pull/14354#discussion_r1243898216



More information about the client-libs-dev mailing list