RFR: 8283214: [macos] Screen magnifier does not show the magnified text for JcomboBox [v3]

Abhishek Kumar abhiscxk at openjdk.org
Fri Jun 30 07:42:07 UTC 2023


> The issue exist only for non-editable combobox and the root cause is accessible object is not created due to incorrect index returned from component class which results in no a11y API invoked.
> 
> Proposed solution is to return the correct accessible child from getAccessibleChild method which is AquaComboBoxButton (arrowButton) instance and that results in invoking the a11y APIs to return the current selected item in combobox. 
> 
> Further when the application comes up first time the accessible name is not set for current displayed item in JCombobox that is handled in AquaComboBoxButton which will take care for the current selected item as well as if user modifies the selection by drop-down list.
> 
> CI link is posted in JBS.

Abhishek Kumar has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:

 - Explicit frame dispose remove
 - merge
 - Review comment update
 - JComboBox selected item  screen magnifier fix

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/14497/files
  - new: https://git.openjdk.org/jdk/pull/14497/files/db0a35b7..1cdc34dc

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=14497&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=14497&range=01-02

  Stats: 16509 lines in 717 files changed: 8810 ins; 4008 del; 3691 mod
  Patch: https://git.openjdk.org/jdk/pull/14497.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/14497/head:pull/14497

PR: https://git.openjdk.org/jdk/pull/14497



More information about the client-libs-dev mailing list