RFR: 8273986: JEditorPane HTML Demo - Accessibility issues
Abhishek Kumar
abhiscxk at openjdk.org
Thu Mar 9 05:11:14 UTC 2023
On Wed, 22 Feb 2023 19:58:08 GMT, Alexander Zuev <kizune at openjdk.org> wrote:
>> JAccessWalker was not able to show component tree correctly if we switch pages for HTML content.
>>
>> Observation:
>> The issue observed is that the children are not reported correct for root element when switching of pages happened. The reason behind it is that the `getAccessibleChildrenCount` API is called on the old `accessibleContext` object which return the children count as 0. Whenever we switch the page the children count is recalculated based on the root element but the `accessibleContext `object used to retrieve the child remains unchanged and due to that it return the children count 0.
>>
>> Solution:
>>
>> Added a condition check to create a new `accessibleContext `object to find out the children count correctly whenever we switch the pages in JEditorPane.
>>
>> Checked with the SwingSet2 JEditorPane demo and it reports well the component tree in JAccessWalker.
>>
>> Steps to verify:
>>
>> JBS contains the steps to reproduce the scenario.
>
> You might to bump up the copyright year in both headers. Other than that looks good.
@azuev-java As discussed earlier, the access specifier for `setElementInfo` method changed from `public` to `protected`. It can't be declared as `private` as method is a part of abstract class.
Please review the latest changes.
-------------
PR: https://git.openjdk.org/jdk/pull/12707
More information about the client-libs-dev
mailing list