RFR: 8302558: Editable JComboBox 's popup blocks user from seeing characters in Acq look and feel [v6]

Prasanta Sadhukhan psadhukhan at openjdk.org
Tue Mar 21 03:17:50 UTC 2023


On Fri, 17 Mar 2023 18:23:33 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> I guess now in JDK with your testcase, popup button are shown opposite to what native components shows ie editable combobox shows non-editable pop-up button and non-editable combobox shows editable pull-down button
>> 
>>  
>> ![image](https://user-images.githubusercontent.com/43534309/225811385-0aea444e-80b3-4608-8a19-31abddaa4501.png)
>> 
>> whereas in native for non-editable one we have pop-up
>> ![image](https://user-images.githubusercontent.com/43534309/225811657-62c3f8c5-9ed2-4ad9-b291-48b55569c79b.png)
>> and for editable we have pull-down
>> ![image](https://user-images.githubusercontent.com/43534309/225812101-9939bd87-d3ef-4f1c-ac32-c5bd37ac647e.png)
>
> This is because the test is set to test for isPopDown set to true, which changes the button appearance for non-editable to be a single down arrow. With this set to false, the button would match native. I have updated the test to test the native instead. Thanks.
> 
> For the editable comboboxes, the only button that is supported is the up and down arrow one shown. So, this one cannot be changed.
> 
> They now show as: 
> <img width="199" alt="Screen Shot 2023-03-17 at 11 23 11 AM" src="https://user-images.githubusercontent.com/96267980/225987450-0ebd0c80-cbea-4601-88d8-3155616c3c0e.png">

The above Apple statement only talks about non-editable combobox but I guess, we have issue, as you told, with editable combobox buttons which as per this code relies on BUTTON_COMBO_BOX state, so I guess we should ask Apple about BUTTON_POP_DOWN support for editable one or any other alternative via JRS

https://github.com/openjdk/jdk/blob/c09f83ec25749af349fb5609e3641b5bb6d34072/src/java.desktop/macosx/classes/com/apple/laf/AquaComboBoxButton.java#L144-L157

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/12750#discussion_r1142853539



More information about the client-libs-dev mailing list