RFR: 6245410: javax.swing.text.html.CSS.Attribute: BACKGROUND_POSITION is not w3c spec compliant

[Alexey Ivanov]

On Tue, 21 Mar 2023 08:31:29 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> [CSS spec for background-position](https://www.w3.org/TR/CSS22/colors.html#propdef-background-position)
> mention the initial value should be "0% 0%" but JDK has the value as "null".
> Rectified the spec violation. 
> No regression is seen in client tests..

Marked as reviewed by aivanov (Reviewer).

test/jdk/javax/swing/text/html/CSS/CSSAttributeComplianceTest.java line 32:

> 30: import javax.swing.text.html.CSS.Attribute;
> 31: 
> 32: public class CSSAttributeComplianceTest{

Suggestion:

public class CSSAttributeComplianceTest {


There's a missing space before the opening brace.

I wonder whether the test is supposed to be extendable… I mean with other attributes. If it's the case, then the suggested name is fine. If it's only for `background-position` attribute, then `BackgroundPositionAttributeTest` could be a better alternative. (The `CSS` part is in the path, so I decided to drop it from the class name.)

-------------

PR Review: https://git.openjdk.org/jdk/pull/13114#pullrequestreview-1350945481
PR Review Comment: https://git.openjdk.org/jdk/pull/13114#discussion_r1143696386