RFR: 8302558: Editable JComboBox 's popup blocks user from seeing characters in Acq look and feel [v6]

Prasanta Sadhukhan psadhukhan at openjdk.org
Thu Mar 23 02:52:42 UTC 2023


On Fri, 17 Mar 2023 18:35:07 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> The issue is in Aqua L&F when an editable JComboBox with a border is used. In this case, when the comboBox is clicked for the drop-down menu to show, the drop-down menu appears at the wrong coordinates (blocking the text of the comboBox and making it unreadable).
>> 
>> This seems to have been the case for a while and a similar issue appeared recently where an editable Aqua JComboBox also had wrong positioning due to having a border.
>> 
>> This fix checks for a border and modifies the bounds to accommodate the border's size. Then the usual calculations for the comboBox popup works as expected.
>> 
>> The new headful test creates an editable comboBox with a TitledBorder and with no border. Then, it automatically clicks the comboBox to open the popup, and clicks where the position of the first selectionItem should be. Finally, it checks if the selected item is correct. This is for all L&F's and the test passes on all OS's.
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update Mac test to match native

Marked as reviewed by psadhukhan (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/12750#pullrequestreview-1353762767



More information about the client-libs-dev mailing list