RFR: 8304501: Remove orphaned demo netbeans projects [v2]

Sergey Bylokhov serb at openjdk.org
Mon Mar 27 05:13:31 UTC 2023


On Mon, 20 Mar 2023 11:24:12 GMT, Eirik Bjorsnos <duke at openjdk.org> wrote:

>> Please review this PR which suggests we remove the orhphaned `SwingApplet` netbeans project directory.
>> 
>> The `SwingApplet` demo was removed in [JDK-8205119](https://bugs.openjdk.org/browse/JDK-8205119), but the netbeans projects files were left behind.
>> 
>> Additionally, the following netbeans projects reference source files that do not exist (if they ever did?):
>> 
>> - src/demo/share/nbproject/management/FullThreadDump
>> - src/demo/share/nbproject/management/JTop
>> - src/demo/share/nbproject/management/MemoryMonitor
>> - src/demo/share/nbproject/management/VerboseGC
>> - src/demo/share/nbproject/scripting/jconsole-plugin
>> 
>> The PR deletes files in these directories as well.
>
> Eirik Bjorsnos has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Delete netbeans project files in src/demo/share/nbproject/management and src/demo/share/nbproject/scripting

Marked as reviewed by serb (Reviewer).

Deleting the SwingApplet looks fine.

-------------

PR Review: https://git.openjdk.org/jdk/pull/13098#pullrequestreview-1358336160
PR Comment: https://git.openjdk.org/jdk/pull/13098#issuecomment-1484505781



More information about the client-libs-dev mailing list