RFR: 8302558: Editable JComboBox 's popup blocks user from seeing characters in Acq look and feel [v6]

[Damon Nguyen]

On Mon, 27 Mar 2023 06:33:11 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update Mac test to match native
>
> test/jdk/javax/swing/JComboBox/EditableComboBoxPopupPos.java line 78:
> 
>> 76:                     String[] comboStrings = {"One", "Two", "Three"};
>> 77: 
>> 78:                     cb1 = new JComboBox(comboStrings);
> 
> Could you please use diamond operator here and after on JComboBox to avoid warnings?

I didn't see this warning myself but I added the operator on the comboboxes.

> test/jdk/javax/swing/JComboBox/EditableComboBoxPopupPos.java line 146:
> 
>> 144:                 checkSelection(cb1Str, cb2Str, cb3Str, cb4Str);
>> 145:             } finally {
>> 146:                 SwingUtilities.invokeAndWait(() -> frame.dispose());
> 
> With null check it will be more robust.

Added

> test/jdk/javax/swing/JComboBox/EditableComboBoxPopupPos.java line 194:
> 
>> 192:         } else {
>> 193:             robot.mouseMove(p.x + width - BUTTON_OFFSET,
>> 194:                     p.y + (height / 2) + POPUP_OFFSET);
> 
> I am having a solid 10 sec delay with Motif LaF for forth ComboBox.
> We are moving mouse really close to the bottom right corner, so resize mouse cursor appears `⤡`.
> This somehow triggers [JDK-8299937](https://bugs.openjdk.org/browse/JDK-8299937)  behavior.
> 
> Without adding `POPUP_OFFSET` all works fine(tested on Mac and Ubuntu).

Removed the offset for the button click

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/12750#discussion_r1149505172
PR Review Comment: https://git.openjdk.org/jdk/pull/12750#discussion_r1149505292
PR Review Comment: https://git.openjdk.org/jdk/pull/12750#discussion_r1149505624