RFR: 8304947: Unnecessary Vector usage in java.awt.MenuBar.shortcuts

Andrey Turbanov aturbanov at openjdk.org
Tue Mar 28 19:53:42 UTC 2023


On Wed, 22 Mar 2023 19:12:34 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

> Method `'java.awt.MenuBar#shortcuts` creates a 'Vector<MenuShortcut>', fills it and then returns its 'Enumeration elements()' as return value.
> Instead of usage of legacy synchronized Vector here we can use ArrayList instead. Wrap it in Collections.enumeration to adapt to 'Enumeration' result type.

src/java.desktop/share/classes/java/awt/Menu.java line 491:

> 489:     }
> 490: 
> 491:     synchronized Enumeration<MenuShortcut> shortcuts() {

Can we change return type to `List<MenuShortcut>` ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13149#discussion_r1147183464



More information about the client-libs-dev mailing list