RFR: 8301616: Drag & maximize to another monitor places window incorrectly (Windows) [v2]

[Nikita Gubarkov]

On Thu, 23 Mar 2023 22:53:43 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> Nikita Gubarkov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8301616: Drag & maximize to another monitor places window incorrectly (Windows)
>
> src/java.desktop/windows/native/libawt/windows/awt_Window.cpp line 374:
> 
>> 372:     WINDOWPOS * wp = (WINDOWPOS *)windowPos;
>> 373: 
>> 374:     // There's no good way to detect partial maximization (e.g. Aero Snap),
> 
> Does the bug affect all windows, or only frames/dialog? Can we move this code to the AwtFrame#WmWindowPosChanging?

I believe it should only affect frames and dialogs, but I don't understand, why it wasn't done for `CheckWindowDPIChange` in the first place, AFAIU this hack is only relevant for frames and dialogs as well. I can move this code into AwtFrame, but then I'd need to loosen visibility of `prevScaleRec` and `m_screenNum`, I personally don't think it worth it. What do you think?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/12367#discussion_r1153462844