RFR: 8283404: [macos] a11y : Screen magnifier does not show JMenu name
Abhishek Kumar
abhiscxk at openjdk.org
Fri Mar 31 17:00:16 UTC 2023
On Fri, 31 Mar 2023 16:34:53 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:
>> It seems that the accessibility role returned by the MenuAccessibility class is not correct for top level menu.
>>
>> Added a condition check to return the accessibility role as `NSAccessibilityMenuBarItemRole` in stead of `NSAccessibilityMenuRole` for top level menu whose parent is `menubar`.
>>
>> The solution works correctly for screen magnifier as well as voice over.
>>
>> A manual test case is added to verify the fix.
>>
>> Note: Tried implementing few a11y methods to fix but for top level menu with `NSAccessibilityMenuRole` doesn't return the a11y label.
>
> test/jdk/javax/accessibility/JMenu/TestJMenuScreenMagnifier.java line 48:
>
>> 46: "System Preference -> Accessibility -> Zoom -> " +
>> 47: "Select ( Enable Hover Text) \n\n" +
>> 48: "2) Run with -Djavax.accessibility.screen_magnifier_present=true" +
>
> What the user should "Run" at this step?
This step is not required. Copy+paste mistake from JBS description.
I will update the test instruction.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13271#discussion_r1154702881
More information about the client-libs-dev
mailing list