RFR: 8305352: updateIconImages may lead to deadlock after JDK-8276849

Phil Race prr at openjdk.org
Fri Mar 31 19:06:16 UTC 2023


On Fri, 31 Mar 2023 09:11:20 GMT, Dmitry Cherepanov <dcherepanov at openjdk.org> wrote:

> Please review this PR which suggests to skip updateIconImages() for not yet visible windows. The displayChanged notification can be sent to a window that is in the process of initiailization and calling updateIconImages() may lead to the deadlock.
> 
> Testing: the deadlock no longer happens with this patch. The reg test for JDK-8276849 works (window icon is updated after changing DPI settings).

that's a good point. If the window is created and later iconifiied (for example) and then this notification comes in, will it be missed ?

-------------

Changes requested by prr (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13263#pullrequestreview-1367452061



More information about the client-libs-dev mailing list