Integrated: JDK-8282232: [Win] GetMousePositionWithPopup test fails due to wrong mouse position
Harshitha Onkar
honkar at openjdk.org
Tue May 2 23:25:25 UTC 2023
On Thu, 6 Apr 2023 23:50:26 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:
> This test issue was due to race condition that occured when using `-Dsun.java2d.uiScale >= 2`.
> As a result it led to incorrect mouse position being compared as opposed to the updated mouse position after the final mouse move event.
>
> Following is the event log before and after fix.
>
> **Before fix:**
>
> 1st mouse move
> 2nd mouse move
> Frame-1 Mouse Event
> Frame-2 Mouse Event
> java.awt.Point[x=29,y=29]
>
>
> **After fix:**
>
> 1st mouse move
> 2nd mouse move
> Frame-1 Mouse Event
> 3rd mouse move
> Frame-2 Mouse Event
> java.awt.Point[x=50,y=50]
>
>
> Earlier Frame-2's mouseMoved() was being triggered on Robot's 2nd mouse move instead of 3rd mouse move. To fix it, the mouseMotionListener for Frame-2 is now added after Robot's 2nd mouse move is processed to avoid the race condition.
>
> The updated test fix is checked on multiple uiScales including fractional scales for windows platform.
> CI testing works as expected on all platforms.
This pull request has now been integrated.
Changeset: 76991c81
Author: Harshitha Onkar <honkar at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/76991c8129a6599a3dfaa0cfdc77a23014a02b35
Stats: 117 lines in 1 file changed: 66 ins; 28 del; 23 mod
8282232: [Win] GetMousePositionWithPopup test fails due to wrong mouse position
Reviewed-by: prr
-------------
PR: https://git.openjdk.org/jdk/pull/13380
More information about the client-libs-dev
mailing list