RFR: 8307145: windowsaccessbridge.dll is missing 4 critical methods in its C API

Artem Semenov asemenov at openjdk.org
Wed May 3 20:00:16 UTC 2023


On Wed, 3 May 2023 17:27:53 GMT, Phil Race <prr at openjdk.org> wrote:

>> In windowsaccessbridge(-64).dll the following methods are exported in a def file to C API which in turn call their real implementation, which are instance methods of the class WinAccessBridge:
>> 
>> addJavaEventNotification
>> removeJavaEventNotification
>> addAccessibilityEventNotification
>> removeAccessibilityEventNotification
>> 
>> 
>> However, they are nowhere to be seen in the actual C interface, in AccessBridgeWindowsEntryPoints.cpp. Your guess is as good as mine as to how on earth MSVC is still capable of compiling and linking this without any errors whatsoever, but in any case, this is a severe oversight and should be properly defined in the C API lest this happy accident within MSVC is fixed by Microsoft in the future
>
> So perhaps something internal in the various accessbridge dll's needs it. How will you test this ?
> Who here has JAWS ? If you don't have JAWS and therefore can't use it to verify the A11Y test suite then
> I don't think you can test this change in a way that makes me comfortable in doing anything here.

@prrace Maybe try using free NVDA for testing?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13734#issuecomment-1533652112



More information about the client-libs-dev mailing list