RFR: 8307165: java/awt/dnd/NoFormatsDropTest/NoFormatsDropTest.java timed out [v3]

[Damon Nguyen]

On Wed, 3 May 2023 21:43:39 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Revert some more changes since irrelevant.
>
> test/jdk/java/awt/dnd/NoFormatsDropTest/NoFormatsDropTest.java line 97:
> 
>> 95:         frame.getToolkit().addAWTEventListener(this, AWTEvent.MOUSE_EVENT_MASK);
>> 96:         frame.pack();
>> 97:         frame.setLocationRelativeTo(null);
> 
> It would be better to retain `frame.setLocationRelativeTo(null)` since you are calling `getLocationOnScreen()` later on.

I have restored the line

> test/jdk/java/awt/dnd/NoFormatsDropTest/NoFormatsDropTest.java line 104:
> 
>> 102:         try {
>> 103:             Robot robot = new Robot();
>> 104:             Thread.sleep(FRAME_ACTIVATION_TIMEOUT);
> 
> Curious to know the difference of using `Thread.sleep()` instead of `robot.delay()` here ?

Initially, I thought ```Thread.sleep``` may have been the cause since there are some synchronization lines. But, I think robot.delay does the same behavior here. So, to keep the modern test format, I reverted this to robot.delay

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13761#discussion_r1185617342
PR Review Comment: https://git.openjdk.org/jdk/pull/13761#discussion_r1185617608