Integrated: 6176679: Application freezes when copying an animated gif image to the system clipboard

Rajat Mahajan rmahajan at openjdk.org
Fri May 5 18:07:33 UTC 2023


On Mon, 10 Apr 2023 21:32:30 GMT, Rajat Mahajan <rmahajan at openjdk.org> wrote:

> **Problem:**
> 
> On pressing the Copy button we keep waiting in AWT-EventQueue thread in reconstruct() function as we detect that we have missing information for the animated image since we are copying single frame at a time.
> Due to this infinite wait the application freezes.
> 
> **Proposed Fix:**
> 
> There are conditions in the reconstruct() function that avoid entering the wait() code if we have some error reading the image , etc. So, I added the condition to avoid entering the wait() code if we are copying single frame at a time. This sounded logical to me since if we have incomplete information(single frame) about the animated image we shouldn’t keep waiting, as it leads to infinite wait. 
> After this change I see the GIF image being correctly copied and animated.
> 
> 
> **Testing:**
> 
> Added a test for this (bug6176679.java) and tested locally on my Windows machine and on mach5.

This pull request has now been integrated.

Changeset: 6c71859a
Author:    Rajat Mahajan <rmahajan at openjdk.org>
Committer: Alexey Ivanov <aivanov at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/6c71859ac240c788364169422e726f8f5443bf75
Stats:     183 lines in 2 files changed: 170 ins; 8 del; 5 mod

6176679: Application freezes when copying an animated gif image to the system clipboard

Reviewed-by: aivanov, dmarkov

-------------

PR: https://git.openjdk.org/jdk/pull/13414



More information about the client-libs-dev mailing list