RFR: 8306996: Open source Swing MenuItem related tests [v2]
Abhishek Kumar
abhiscxk at openjdk.org
Mon May 8 09:33:44 UTC 2023
On Sat, 6 May 2023 00:17:01 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:
>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Review comment update
>
> test/jdk/javax/swing/JMenuItem/bug4839464.java line 29:
>
>> 27: @summary Shortcoming in the way JMenuItem handles 'propertyChange()' events.
>> 28: @library ../../regtesthelpers
>> 29: @build Util JRobot
>
> I see Util is added but I don't see any Util methods used. Is this needed?
>
> Also, did you try running this test after moving it to open? I think you get an error with this ```regtesthelpers``` path since you removed the individual directories for each of these tests and placed them directly into the ```JMenuItem``` dir.
@DamonGuy @honkar-jdk Thanks for pointing out. I missed to run in open. Updated the tests and these tags are removed as they are of no longer use.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13822#discussion_r1187233885
More information about the client-libs-dev
mailing list