RFR: 8307130: Open source few Swing JMenu tests [v2]

Damon Nguyen dnguyen at openjdk.org
Mon May 8 18:58:40 UTC 2023


On Mon, 8 May 2023 18:36:08 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add Util. Change helper path
>
> test/jdk/javax/swing/JMenu/bug5013739.java line 85:
> 
>> 83:             robo.delay(1000);
>> 84:         } finally {
>> 85:             SwingUtilities.invokeAndWait(() -> mainFrame.dispose());
> 
> probably doesn't matter, but should this check if mainFrame != null?

I agree it shouldn't matter here. I added it anyway

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13839#discussion_r1187780486



More information about the client-libs-dev mailing list