RFR: 7083187: Class CSS.CssValue is missing implementations of equals() and hashCode() [v2]

Prasanta Sadhukhan psadhukhan at openjdk.org
Tue May 9 03:28:23 UTC 2023


On Fri, 5 May 2023 17:50:54 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> yes this needs to be changed.
>> Also needs to be changed at line 2034.
>
> The following test still fails.
> 
> 
>     private static void testFontFamilyCSS() {
>         StyleSheet ss = new StyleSheet();
> 
>         AttributeSet a = ss.getDeclaration("font-family: sans-serif");
>         AttributeSet b = ss.getDeclaration("font-family: sans-serif");
>         // Verify a.isEqual(b)
>     }

String comparison changed.
Also, I am not able to see this test fail in latest iteration..

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13405#discussion_r1188075885



More information about the client-libs-dev mailing list