RFR: 7083187: Class CSS.CssValue is missing implementations of equals() and hashCode() [v4]

Prasanta Sadhukhan psadhukhan at openjdk.org
Tue May 9 03:51:30 UTC 2023


On Thu, 4 May 2023 12:42:14 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   More Attrbutes added
>
> test/jdk/javax/swing/text/html/CSS/CSSAttributeEqualityBug.java line 119:
> 
>> 117:             System.out.println("b = " + b);
>> 118:             throw new RuntimeException("CSS.Attribute.Color a is not equal to b");
>> 119:         }
> 
> Does it make sense to introduce a new method which compares the two attributes sets `a` and `b`, prints messages and throws the exception? You'll need to pass the CSS attribute name to it. The code will be cleaner.

ok

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13405#discussion_r1188088524



More information about the client-libs-dev mailing list