RFR: 7083187: Class CSS.CssValue is missing implementations of equals() and hashCode() [v4]
Prasanta Sadhukhan
psadhukhan at openjdk.org
Tue May 9 06:44:23 UTC 2023
On Fri, 5 May 2023 17:59:25 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>>
>> More Attrbutes added
>
> src/java.desktop/share/classes/javax/swing/text/html/CSS.java line 2897:
>
>> 2895: @Override
>> 2896: public int hashCode() {
>> 2897: return Float.hashCode(horizontalPosition);
>
> For better hashing, `verticalPosition` should also be taken into account.
ok
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13405#discussion_r1188199148
More information about the client-libs-dev
mailing list