RFR: 8306812: Open source several AWT Miscellaneous tests [v2]
Damon Nguyen
dnguyen at openjdk.org
Wed May 10 17:42:19 UTC 2023
On Mon, 8 May 2023 18:05:59 GMT, Tejesh R <tr at openjdk.org> wrote:
>> Open source few AWT Miscellaneous ( Panel, Popup, robot and scrollbar) tests.
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
>
> Updated based on review comments
Changes requested by dnguyen (Committer).
test/jdk/java/awt/PopupMenu/PopupMenuStayOpen.java line 24:
> 22: */
> 23: /*
> 24: @test
Separate these comment blocks with a newline
test/jdk/java/awt/Robot/RobotMoveMultiscreen.java line 24:
> 22: */
> 23: /*
> 24: @test
Same. Needs newline
test/jdk/java/awt/Robot/RobotMoveMultiscreen.java line 81:
> 79: robot.waitForIdle();
> 80:
> 81: if(testCondition == false) {
Space after "if"
-------------
PR Review: https://git.openjdk.org/jdk/pull/13828#pullrequestreview-1421027876
PR Review Comment: https://git.openjdk.org/jdk/pull/13828#discussion_r1190162788
PR Review Comment: https://git.openjdk.org/jdk/pull/13828#discussion_r1190164290
PR Review Comment: https://git.openjdk.org/jdk/pull/13828#discussion_r1190165280
More information about the client-libs-dev
mailing list