RFR: 8306996: Open source Swing MenuItem related tests [v2]

Harshitha Onkar honkar at openjdk.org
Wed May 10 20:47:46 UTC 2023


On Mon, 8 May 2023 09:33:40 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> This PR is to open source JMenuItem related swing tests.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comment update

test/jdk/javax/swing/JMenuItem/bug4839464.java line 68:

> 66:     public static KeyStroke ks2 =
> 67:             KeyStroke.getKeyStroke(KeyEvent.VK_F1,
> 68:                                    KeyEvent.CTRL_MASK);

Since SHIFT_MASK and CTRK_MASK are deprecated, you can use the new extended modifier constants here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13822#discussion_r1190378262



More information about the client-libs-dev mailing list