RFR: 8306996: Open source Swing MenuItem related tests [v3]

Prasanta Sadhukhan psadhukhan at openjdk.org
Thu May 11 06:39:42 UTC 2023


On Thu, 11 May 2023 06:20:56 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> This PR is to open source JMenuItem related swing tests.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Shift and Control mask modified

test/jdk/javax/swing/JMenuItem/bug4966168.java line 26:

> 24: /*  @test
> 25:     @bug 4966168
> 26:     @summary JInternalFrame not serializable in Motif & GTK L&F

I dont see the test being tested for Motif & GTK which are not default L&F...Probably we should iterate for all L&F just to be sure..
Also, all `throw new Error` should ideally be changed to `throw new RuntimeException` for all tests in this PR..

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13822#discussion_r1190698651



More information about the client-libs-dev mailing list