RFR: 8306996: Open source Swing MenuItem related tests [v4]
Abhishek Kumar
abhiscxk at openjdk.org
Thu May 11 10:25:51 UTC 2023
On Thu, 11 May 2023 10:05:48 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:
>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Check for all LAFs
>
> test/jdk/javax/swing/JMenuItem/bug4966168.java line 63:
>
>> 61: } catch (Exception e) {
>> 62: System.out.println("Look and Feel not set: " + laf.getClassName());
>> 63: continue;
>
> It should be only for UnsupportedLookAndFeelException...other Exception should fail the test..
Updated.
> test/jdk/javax/swing/JMenuItem/bug4966168.java line 70:
>
>> 68: } catch (Exception e) {
>> 69: throw new RuntimeException(e);
>> 70: }
>
> guess no need of try-catch..if there are exceptions, let it fail with original Exception
Updated.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13822#discussion_r1190959049
PR Review Comment: https://git.openjdk.org/jdk/pull/13822#discussion_r1190959161
More information about the client-libs-dev
mailing list