RFR: 8307779: Relax the java.awt.Robot specification [v2]

Phil Race prr at openjdk.org
Thu May 11 22:02:02 UTC 2023


On Wed, 10 May 2023 20:41:06 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> src/java.desktop/share/classes/java/awt/Robot.java line 478:
>> 
>>> 476:      * @throws  SecurityException if {@code readDisplayPixels} permission
>>> 477:      *          is not granted, or user has not allowed any of his screens
>>> 478:      *          to be captured.
>> 
>> "user" -> "the user"
>> "his" -> gender neutral "their".
>> Or maybe better ", or access to the screen is denied by the desktop environment"
>
> Updated to the former for now.

I think you should draft the CSR now based on the current text.
We may still need to tweak words like
"or the user has not allowed any of their screens to be captured."
based on developing understanding, or perhaps being careful not to be describe in the docs what happens to be the pipewire behaviour.
In fact that is why I suggested my other words, because (1) there may be no user involved and
(2) screen vs screens seems to be a pipewire / wayland concept. I'm pretty sure macOS just treats it as "the desktop" no matter how many monitors are involved.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13809#discussion_r1191730203



More information about the client-libs-dev mailing list