RFR: 8306812: Open source several AWT Miscellaneous tests [v3]
Tejesh R
tr at openjdk.org
Fri May 12 03:35:46 UTC 2023
On Thu, 11 May 2023 21:50:06 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:
>> Tejesh R has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Updated based on review comments
>> - Updated based on review comments
>
> test/jdk/java/awt/Scrollbar/ScrollbarKeyControlTest.java line 143:
>
>> 141: robot.keyPress(KeyEvent.VK_END);
>> 142: robot.keyRelease(KeyEvent.VK_END);
>> 143: LOCK.wait(2000);
>
> @TejeshR13 Is a delay of 2s required between key presses? Seems a bit more than usual.
This is not a delay, maximum wait time is 2sec which doesn't seem to happen during the test execution unless scrollbar adjustment is not invoked. I think max wait time of 2sec in case of unlock failure is fine.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13828#discussion_r1191872271
More information about the client-libs-dev
mailing list