RFR: 8289547 : Update javax/swing/Popup/TaskbarPositionTest.java

Renjith Kannath Pariyangad duke at openjdk.org
Fri May 12 05:03:46 UTC 2023


On Thu, 11 May 2023 16:50:00 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> The new version of the test fails for me on macOS because CTRL + DOWN key combination is reserved by the operating system. It is necessary to disable "Application windows" system key shortcut to execute the test without failure.
>> An interesting thing is that the old version of the test works fine even if "Application windows" system key shortcut is enabled.
>> I would suggest documenting (probably at testing.md/wiki page) that "Application windows" key shortcut should be disabled prior testing.
>
>> The new version of the test fails for me on macOS because CTRL + DOWN key combination is reserved by the operating system. It is necessary to disable "Application windows" system key shortcut to execute the test without failure.
> 
> Yes, it's known. It is recommended to disable all system shortcuts for running client tests, see [the requirements on the wiki](https://wiki.openjdk.org/display/ClientLibs/Automated+client+GUI+testing+system+set+up+requirements#AutomatedclientGUItestingsystemsetuprequirements-macOS-SpecificSystemsetupnotes), which may be unfeasible for a system one uses day-to-day.
> 
>> An interesting thing is that the old version of the test works fine even if "Application windows" system key shortcut is enabled.
> 
> It's because the old test didn't open that popup or didn't check its position, I can't remember for sure.
> 
>> I would suggest documenting (probably at testing.md/wiki page) that "Application windows" key shortcut should be disabled prior testing.
> 
> It is already documented per the comment above.
> 
> Do you also suggest changing the key stroke to another combination?

@aivanov-jdk , you are right "_the old test didn't open that popup and check its position_" and similarly some other cases also missed and that was the reason for updating the test case.
Thank you @dmarkov20 bringing this point up and @honkar-jdk for your recommendation. Since system per-requirement is well documented look like we can keep it as it is. @aivanov-jdk please share your recommendation will update based on this.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13578#issuecomment-1545142377



More information about the client-libs-dev mailing list