RFR: JDK-8308110: Resolve multiple definition of 'JNI_OnLoad_jsound' linking error

Tue May 16 14:54:45 UTC 2023

On Tue, 16 May 2023 05:40:34 GMT, Alan Bateman <alanb at openjdk.org> wrote:

> Probably should wait for someone in the client libs area to review too but I think this is okay. It would require digging into the history to know how the duplicate came about when it is already defined in Platform.c.

Thanks for the review. Will wait for additional review as suggested.

According to `blame`, `DEF_STATIC_JNI_OnLoad` in PLATFORM_API_LinuxOS_ALSA_CommonUtils.c was added by https://github.com/openjdk/jdk/commit/3dc2d0258537bae096be7c15ac7cfc28b2729a53 for `8136556: Add the ability to perform static builds of MacOSX x64 binaries`. `DEF_STATIC_JNI_OnLoad` in libjsound/Platform.c was added in the same commit.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13994#issuecomment-1549831475