RFR: 7083187: Class CSS.CssValue is missing implementations of equals() and hashCode() [v7]

Prasanta Sadhukhan psadhukhan at openjdk.org
Wed May 17 03:49:45 UTC 2023


On Tue, 9 May 2023 06:44:20 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Two CSS AttributeSet-s can be compared using the AttributeSet.isEqual() method which can fail due to missing implementation of equals method in CSS subclasses.
>> In this issue, even when two CSS AttributeSet has same 42 font size string value, Object equality fails.
>> Fixed by implementing the equality and hashCode method for CSS.FontSize class.
>> 
>> All jtreg/jck tests are ok
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   hashCode fix

@prrace @aivanov-jdk Any other comments for this PR?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13405#issuecomment-1550655311



More information about the client-libs-dev mailing list