RFR: 8307105: JFileChooser InvalidPathException when selecting some system folders on Windows [v2]

Tejesh R tr at openjdk.org
Wed May 17 05:30:55 UTC 2023


On Wed, 17 May 2023 03:35:16 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Updated based on review comments
>
> test/jdk/javax/swing/JFileChooser/FileChooserIPETest.java line 80:
> 
>> 78:         frame.add(jfc, BorderLayout.CENTER);
>> 79:         frame.pack();
>> 80:         frame.setVisible(true);
> 
> Do we need to dispose the frame?

Not required when its been added to PassFailJFrame. PassFailJFrame takes care of frame dispose.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13998#discussion_r1195952498



More information about the client-libs-dev mailing list