RFR: 8296920: Regression Test DialogOrient.java fails on MacOS

Alisen Chung achung at openjdk.org
Wed May 17 21:50:50 UTC 2023


On Fri, 12 May 2023 09:03:07 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Test was failing with PrinterException: Wrong Orientation since printing was done with default orientation.
> Fix is made to set the printable with correct PageFormat
> 
> It was not seen prior to [JDK-8262731](https://bugs.openjdk.org/browse/JDK-8262731) probably because the exception was being swallowed..

test/jdk/java/awt/print/Dialog/DialogOrient.java line 73:

> 71:         PrinterJob job = PrinterJob.getPrinterJob();
> 72:         PageFormat landscape = job.pageDialog(job.defaultPage());
> 73:         job.setPrintable(new DialogOrient(), landscape);

why doesn't job.setPrintable(DialogOrient) work here? doesn't job.pageDialog already set the job orientation to landscape?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13950#discussion_r1197084889



More information about the client-libs-dev mailing list