RFR: 8307105: JFileChooser InvalidPathException when selecting some system folders on Windows [v3]
Tejesh R
tr at openjdk.org
Thu May 18 05:27:53 UTC 2023
On Wed, 17 May 2023 16:25:59 GMT, Tejesh R <tr at openjdk.org> wrote:
>> I technically had 2 questions in the last comment.
>> 1. Can't you just put the contents of `initialize()` in place of line 53? It's the only thing being run.
>> 2. Why are we creating a `Runnable` instance instead of just calling `initialize` in main?
>>
>> And I have another completely separate comment. If you actually need this to be a `Runnable`, I think you can replace this with a lambda function.
>
> Point 1 can be done, nothing specific to adding everything into a function. Just that we are trying to maintain uniformity across other test. Point 2, it can be either with Runnable/direct lambda function, just that no return type is there we can use Runnable too I just choose it, nothing specific to functionlity.
Updated by removing `Runnable`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13998#discussion_r1197385063
More information about the client-libs-dev
mailing list